On Tue, 11 Feb 2025 15:48:51 -0800 Shannon Nelson <shannon.nelson@xxxxxxx> wrote: > Add support for a new fwctl-based auxiliary_device for creating a > channel for fwctl support into the AMD/Pensando DSC. > > Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxx> Hi Shannon, > diff --git a/drivers/net/ethernet/amd/pds_core/main.c b/drivers/net/ethernet/amd/pds_core/main.c > index a3a68889137b..7f20c3f5f349 100644 > --- a/drivers/net/ethernet/amd/pds_core/main.c > +++ b/drivers/net/ethernet/amd/pds_core/main.c > @@ -265,6 +265,10 @@ static int pdsc_init_pf(struct pdsc *pdsc) > > mutex_unlock(&pdsc->config_lock); > > + err = pdsc_auxbus_dev_add(pdsc, pdsc, PDS_DEV_TYPE_FWCTL, &pdsc->padev); > + if (err) > + goto err_out_teardown; > + If you fail after this point, do you not want to remove this device? Also superficially shouldn't this be goto err_out_stop? I think the call is just after pdsc_start(pdsc) though maybe I'm looking at an old tree. > dl = priv_to_devlink(pdsc); > devl_lock(dl); > err = devl_params_register(dl, pdsc_dl_params,
