On Mon, 3 Feb 2025 13:09:31 -0800 Tony Nguyen wrote:
> + if (val.vu32 > pf->hw.func_caps.common_cap.num_msix_vectors ||
> + val.vu32 < pf->msix.min) {
> + NL_SET_ERR_MSG_MOD(extack, "Value is invalid");
> + return -EINVAL;
> + if (val.vu32 < ICE_MIN_MSIX || val.vu32 > pf->msix.max) {
> + NL_SET_ERR_MSG_MOD(extack, "Value is invalid");
> + return -EINVAL;
Please follow up and either remove these extack messages, or make them
more meaningful. The "value is invalid" is already expressed by EINVAL
The suggestion to set the values at once or as "pending" is a
distraction IMO.
