On 25/12/2024 15:15, Michael Margolin wrote: > Make sure the device is being reset on driver exit whatever the reason > is, to keep the device aligned and allow it to close shared resources > (e.g. admin queue). > > Reviewed-by: Firas Jahjah <firasj@xxxxxxxxxx> > Reviewed-by: Yonatan Nachum <ynachum@xxxxxxxxxx> > Signed-off-by: Michael Margolin <mrgolin@xxxxxxxxxx> > --- > @@ -685,7 +685,7 @@ static void efa_remove(struct pci_dev *pdev) > struct efa_dev *dev = pci_get_drvdata(pdev); > > efa_ib_device_remove(dev); This already calls efa_com_dev_reset(), you now perform double reset in the normal remove flow. > - efa_remove_device(pdev); > + efa_remove_device(pdev, false); > }
