Re: [PATCH 1/4] RDMA/core: Remove unused ib_ud_header_unpack

Kalesh Anakkur Purayil <kalesh-anakkur.purayil@xxxxxxxxxxxx> · Mon, 23 Dec 2024 08:59:50 +0530



On Sat, Dec 21, 2024 at 7:11 AM <linux@xxxxxxxxxxx> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> ib_ud_header_unpack() is unused, and I can't see any sign of it
> ever having been used in git.  The only reference I can find
> is from December 2004 BKrev: 41d30034XNbBUl0XnyC6ig9V61Nf-A when
> it looks like it was added.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> ---
>  drivers/infiniband/core/ud_header.c | 83 -----------------------------
>  include/rdma/ib_pack.h              |  3 --
>  2 files changed, 86 deletions(-)
>
> diff --git a/drivers/infiniband/core/ud_header.c b/drivers/infiniband/core/ud_header.c
> index 64d9c492de64..8d3dfef9ebaa 100644
> --- a/drivers/infiniband/core/ud_header.c
> +++ b/drivers/infiniband/core/ud_header.c
> @@ -462,86 +462,3 @@ int ib_ud_header_pack(struct ib_ud_header *header,
>         return len;

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>

-- 
Regards,
Kalesh AP
Attachment:
smime.p7s

Description: S/MIME Cryptographic Signature