Re: [PATCH-next] RDMA/erdma: Fix opcode conditional check

[Cheng Xu <chengyou@xxxxxxxxxxxxxxxxx>]

On 12/19/24 12:39 PM, Advait Dhamorikar wrote:
> Fix conditional if else check by checking with wr->opcode.
> The indicated dead code may have performed some action; that
> action will never occur as op is pre-assigned a different value.
> 
> Signed-off-by: Advait Dhamorikar <advaitdhamorikar@xxxxxxxxx>
> ---
>  drivers/infiniband/hw/erdma/erdma_qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Cheng Xu <chengyou@xxxxxxxxxxxxxxxxx>

Thanks very much,
Cheng Xu

> diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c
> index 4dfb4272ad86..5c266918fb36 100644
> --- a/drivers/infiniband/hw/erdma/erdma_qp.c
> +++ b/drivers/infiniband/hw/erdma/erdma_qp.c
> @@ -406,7 +406,7 @@ static void init_send_sqe_rc(struct erdma_qp *qp, struct erdma_send_sqe_rc *sqe,
>  	if (wr->opcode == IB_WR_SEND_WITH_IMM) {
>  		op = ERDMA_OP_SEND_WITH_IMM;
>  		sqe->imm_data = wr->ex.imm_data;
> -	} else if (op == IB_WR_SEND_WITH_INV) {
> +	} else if (wr->opcode == IB_WR_SEND_WITH_INV) {
>  		op = ERDMA_OP_SEND_WITH_INV;
>  		sqe->invalid_stag = cpu_to_le32(wr->ex.invalidate_rkey);
>  	}