Hi Tariq, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Tariq-Toukan/net-mlx5-ifc-Reorganize-mlx5_ifc_flow_table_context_bits/20241204-124235 base: net-next/main patch link: https://lore.kernel.org/r/20241203202924.228440-8-tariqt%40nvidia.com patch subject: [PATCH net-next V4 07/11] devlink: Extend devlink rate API with traffic classes bandwidth management config: arm-randconfig-001 (https://download.01.org/0day-ci/archive/20241205/202412050552.sNZ6Y79O-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050552.sNZ6Y79O-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202412050552.sNZ6Y79O-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from include/uapi/linux/neighbour.h:6, from include/linux/netdevice.h:44, from include/linux/etherdevice.h:21, from net/devlink/devl_internal.h:7, from net/devlink/rate.c:7: net/devlink/rate.c: In function 'devlink_nl_rate_tc_bw_set': >> include/linux/netlink.h:116:13: warning: ' traffic classes must be spe...' directive output truncated writing 34 bytes into a region of size 32 [-Wformat-truncation=] 116 | if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 117 | "%s" fmt "%s", "", ##args, "") >= \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/devlink/rate.c:403:25: note: in expansion of macro 'NL_SET_ERR_MSG_FMT' 403 | NL_SET_ERR_MSG_FMT(info->extack, | ^~~~~~~~~~~~~~~~~~ include/linux/netlink.h:116:13: note: 'snprintf' output 83 bytes into a destination of size 80 116 | if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 117 | "%s" fmt "%s", "", ##args, "") >= \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/devlink/rate.c:403:25: note: in expansion of macro 'NL_SET_ERR_MSG_FMT' 403 | NL_SET_ERR_MSG_FMT(info->extack, | ^~~~~~~~~~~~~~~~~~ vim +116 include/linux/netlink.h 2d4bc93368f5a0d Johannes Berg 2017-04-12 107 51c352bdbcd23d7 Edward Cree 2022-10-18 108 /* We splice fmt with %s at each end even in the snprintf so that both calls 51c352bdbcd23d7 Edward Cree 2022-10-18 109 * can use the same string constant, avoiding its duplication in .ro 51c352bdbcd23d7 Edward Cree 2022-10-18 110 */ 51c352bdbcd23d7 Edward Cree 2022-10-18 111 #define NL_SET_ERR_MSG_FMT(extack, fmt, args...) do { \ 51c352bdbcd23d7 Edward Cree 2022-10-18 112 struct netlink_ext_ack *__extack = (extack); \ 51c352bdbcd23d7 Edward Cree 2022-10-18 113 \ 51c352bdbcd23d7 Edward Cree 2022-10-18 114 if (!__extack) \ 51c352bdbcd23d7 Edward Cree 2022-10-18 115 break; \ 51c352bdbcd23d7 Edward Cree 2022-10-18 @116 if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \ 51c352bdbcd23d7 Edward Cree 2022-10-18 117 "%s" fmt "%s", "", ##args, "") >= \ 51c352bdbcd23d7 Edward Cree 2022-10-18 118 NETLINK_MAX_FMTMSG_LEN) \ 51c352bdbcd23d7 Edward Cree 2022-10-18 119 net_warn_ratelimited("%s" fmt "%s", "truncated extack: ", \ 51c352bdbcd23d7 Edward Cree 2022-10-18 120 ##args, "\n"); \ 51c352bdbcd23d7 Edward Cree 2022-10-18 121 \ 51c352bdbcd23d7 Edward Cree 2022-10-18 122 do_trace_netlink_extack(__extack->_msg_buf); \ 51c352bdbcd23d7 Edward Cree 2022-10-18 123 \ 51c352bdbcd23d7 Edward Cree 2022-10-18 124 __extack->_msg = __extack->_msg_buf; \ 51c352bdbcd23d7 Edward Cree 2022-10-18 125 } while (0) 51c352bdbcd23d7 Edward Cree 2022-10-18 126 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
