On Tue, Nov 26, 2024 at 6:40 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> res->dattr is always valid at this point as it was initialized
> during device addition in bnxt_re_add_device().
>
> This change is fixing the following smatch error:
> drivers/infiniband/hw/bnxt_re/qplib_fp.c:1090 bnxt_qplib_create_qp()
> error: we previously assumed 'res->dattr' could be null (see line 985)
>
> Fixes: 07f830ae4913 ("RDMA/bnxt_re: Adds MSN table capability for Gen P7 adapters")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/r/202411222329.YTrwonWi-lkp@xxxxxxxxx/
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
Thanks,
Selvin
> ---
> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> index 256c4379ab7f..90e4faebef09 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> @@ -995,9 +995,7 @@ int bnxt_qplib_create_qp(struct bnxt_qplib_res *res, struct bnxt_qplib_qp *qp)
> u32 tbl_indx;
> u16 nsge;
>
> - if (res->dattr)
> - qp->is_host_msn_tbl = _is_host_msn_table(res->dattr->dev_cap_flags2);
> -
> + qp->is_host_msn_tbl = _is_host_msn_table(res->dattr->dev_cap_flags2);
> sq->dbinfo.flags = 0;
> bnxt_qplib_rcfw_cmd_prep((struct cmdq_base *)&req,
> CMDQ_BASE_OPCODE_CREATE_QP,
> --
> 2.47.0
>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
