On Sat, Nov 16, 2024 at 3:54 AM Saeed Mahameed <saeed@xxxxxxxxxx> wrote: > > On 15 Nov 11:24, Jakub Kicinski wrote: > >On Fri, 15 Nov 2024 00:01:50 -0800 Saeed Mahameed wrote: > >> not rx_missed_errors please, it is exclusive for software lack of buffers. > >> > >> Please have a look at thtool_eth_XXX_stats IEEE ethnl_stats, if you need to > >> extend, this is the place. > >> > >> RFC2863[1] defines this type of discards as ifInDiscards. So let's add > >> it to ehttool std stats. mlx5 reports most of them already to driver custom > >> ethtool -S > > > >We can, but honestly I'd just make sure they are counted in rx_dropped > > rx_dropped: Number of packets received but not processed, > * e.g. due to lack of resources or unsupported protocol. > * For hardware interfaces this counter may include packets discarded > * due to L2 address filtering but should not include packets dropped > ^^^^^^^^^^^^^^ > * by the device due to buffer exhaustion which are counted separately in > ^^^^^^^^^^^^^^^^^ > * @rx_missed_errors (since procfs folds those two counters together). > ^^^^^^^^^^^^^^^^^ > > I think we should use rx_fifo_errors for this and update documentation: Hello Saeed, Could we apply the change to `drivers/net/ethernet/mellanox/mlx5/core/en_main.c` first and update the documentation in a future patch? Updating the documentation perfectly seems like a challenging task, and I’m not the best person for that job ;) -- Regards Yafang
