Re: [PATCH v2 RESEND] net/mlx5: unique names for per device caches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 23/10/2024 16:41, Sebastian Ott wrote:
Add the device name to the per device kmem_cache names to
ensure their uniqueness. This fixes warnings like this:
"kmem_cache of name 'mlx5_fs_fgs' already exists".

Reviwed-by: Breno Leitao <leitao@xxxxxxxxxx>
Signed-off-by: Sebastian Ott <sebott@xxxxxxxxxx>
---
  drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 8505d5e241e1..c2db0a1c132b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -3689,6 +3689,7 @@ void mlx5_fs_core_free(struct mlx5_core_dev *dev)
  int mlx5_fs_core_alloc(struct mlx5_core_dev *dev)
  {
  	struct mlx5_flow_steering *steering;
+	char name[80];
  	int err = 0;
err = mlx5_init_fc_stats(dev);
@@ -3713,10 +3714,12 @@ int mlx5_fs_core_alloc(struct mlx5_core_dev *dev)
  	else
  		steering->mode = MLX5_FLOW_STEERING_MODE_DMFS;
- steering->fgs_cache = kmem_cache_create("mlx5_fs_fgs",
+	snprintf(name, sizeof(name), "%s-mlx5_fs_fgs", dev_name(dev->device));
+	steering->fgs_cache = kmem_cache_create(name,
  						sizeof(struct mlx5_flow_group), 0,
  						0, NULL);
-	steering->ftes_cache = kmem_cache_create("mlx5_fs_ftes", sizeof(struct fs_fte), 0,
+	snprintf(name, sizeof(name), "%s-mlx5_fs_ftes", dev_name(dev->device));
+	steering->ftes_cache = kmem_cache_create(name, sizeof(struct fs_fte), 0,
  						 0, NULL);
  	if (!steering->ftes_cache || !steering->fgs_cache) {
  		err = -ENOMEM;

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Thanks.




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux