Re: [PATCH] RDMA/efa: Fix node guid compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/27/2024 1:34 AM, Jason Gunthorpe wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On Thu, Sep 26, 2024 at 11:03:57PM +0300, Margolin, Michael wrote:
On 9/26/2024 5:54 PM, Jason Gunthorpe wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On Thu, Sep 26, 2024 at 04:25:19PM +0300, Margolin, Michael wrote:

Actually that's wrong, the device always sets guid in BE order so no
swap is needed in the driver in any case.
They you just mark it as _be64 in the struct and there is no reason
for the __force ?

Jason
That's probably the most correct way but I prefer to avoid introducing
kernel specific types in a shared interface file.
?

what is a "shared interface file" ?

That doesn't sound like a linux thing

Jason

Nothing particularly related to linux, just a common practice of having the same interface on both sides (driver and device in this case).

Michael





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux