On Wed, 11 Sep 2024 23:38:45 -0700 Krzysztof Olędzki wrote: > Use SFF8024 constants defined in linux/sfp.h instead of private ones. > > Make mlx4_en_get_module_info() and mlx5e_get_module_info() to look > as close as possible to each other. > > Simplify the logic for selecting SFF_8436 vs SFF_8636. Minor process suggestion, I think you may be sending the patches one by one. It's best to format them into a new directory and send all at once with git send-email. Add a cover letter, too.