Re: [PATCH v3 rdma-next 2/7] RDMA/mlx5: Obtain upper net device only when needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 9, 2024 at 11:10 PM Michael Guralnik <michaelgur@xxxxxxxxxx> wrote:
>
> From: Mark Bloch <mbloch@xxxxxxxxxx>
>
> Report the upper device's state as the RDMA port state only in RoCE LAG or
> switchdev LAG.
>
> Fixes: 27f9e0ccb6da ("net/mlx5: Lag, Add single RDMA device in multiport mode")
> Signed-off-by: Mark Bloch <mbloch@xxxxxxxxxx>
> Signed-off-by: Michael Guralnik <michaelgur@xxxxxxxxxx>
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
Looks good to me
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/mlx5/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index cdf1ce0f6b34..c75cc3d14e74 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -558,7 +558,7 @@ static int mlx5_query_port_roce(struct ib_device *device, u32 port_num,
>         if (!ndev)
>                 goto out;
>
> -       if (dev->lag_active) {
> +       if (mlx5_lag_is_roce(mdev) || mlx5_lag_is_sriov(mdev)) {
>                 rcu_read_lock();
>                 upper = netdev_master_upper_dev_get_rcu(ndev);
>                 if (upper) {
> --
> 2.17.2
>
>


-- 
Regards,
Kalesh A P

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux