On Thu, Sep 5, 2024 at 3:59 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> On Tue, Sep 03, 2024 at 04:30:50AM -0700, Selvin Xavier wrote:
> > From: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> >
> > QP1 context in HW needs to be updated when there is a
> > change in the default DSCP values used for RoCE traffic.
> > Handle the event from FW and modify the dscp value used
> > by QP1.
> >
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> > Signed-off-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> > ---
> > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 1 +
> > drivers/infiniband/hw/bnxt_re/main.c | 105 +++++++++++++++++++++++++++++++
> > drivers/infiniband/hw/bnxt_re/qplib_fp.h | 2 +
> > drivers/infiniband/hw/bnxt_re/qplib_sp.h | 1 +
> > 4 files changed, 109 insertions(+)
>
> <...>
>
> > +static void bnxt_re_uninit_dcb_wq(struct bnxt_re_dev *rdev)
> > +{
> > + if (!rdev->dcb_wq)
> > + return;
> > + flush_workqueue(rdev->dcb_wq);
> > + destroy_workqueue(rdev->dcb_wq);
>
> There is no need in flush_workqueue() as destroy_workqueue() will do it.
>
> > + rdev->dcb_wq = NULL;
>
> Is this assignment needed?
Ack. Will remove this when we post v2.
>
> > +}
>
> Thanks
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
