> -----Original Message----- > From: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx> > Sent: Sunday, September 1, 2024 11:46 PM > To: linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx > Cc: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan > <kys@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Wei Liu > <wei.liu@xxxxxxxxxx>; Dexuan Cui <decui@xxxxxxxxxxxxx>; David S. Miller > <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski > <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Long Li > <longli@xxxxxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; Konstantin > Taranov <kotaranov@xxxxxxxxxxxxx>; Souradeep Chakrabarti > <schakrabarti@xxxxxxxxxxxxxxxxxxx>; Erick Archer > <erick.archer@xxxxxxxxxxx>; Pavan Chebbi <pavan.chebbi@xxxxxxxxxxxx>; > Ahmed Zaki <ahmed.zaki@xxxxxxxxx>; Colin Ian King > <colin.i.king@xxxxxxxxx>; Shradha Gupta <shradhagupta@xxxxxxxxxxxxx> > Subject: [PATCH net-next v2] net: mana: Improve mana_set_channels() in > low mem conditions > > The mana_set_channels() function requires detaching the mana > driver and reattaching it with changed channel values. > During this operation if the system is low on memory, the reattach > might fail, causing the network device being down. > To avoid this we pre-allocate buffers at the beginning of set operation, > to prevent complete network loss > > Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx> Thanks. Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>