On Tue, Jun 25, 2024 at 02:28:24PM +0300, Margolin, Michael wrote: > > On 6/25/2024 9:33 AM, Gal Pressman wrote: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > On 24/06/2024 19:09, Michael Margolin wrote: > > > From: Yonatan Nachum <ynachum@xxxxxxxxxx> > > > > > > When creating a new CQ with interrupts enabled, the caller needs to > > > specify an EQ index to which the interrupts will be sent on, we don't > > > validate the requested index in the EQ array. > > > Validate out of bound reach of the EQ array and return an error. > > > > > > This is not a bug because IB core validates the requested EQ number when > > > creating a CQ. > > Then why is this patch needed? > > Mainly as best practice of validating the index right before array access to > avoid hard to catch bugs. If you know about the bug, please fix it. There is no need to add code "to protect" low level from incorrect upper level. Thanks > > Michael > >
