Re: [PATCH for-next 4/5] RDMA/efa: Move type conversion helpers to efa.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/25/2024 9:33 AM, Gal Pressman wrote

On 24/06/2024 19:09, Michael Margolin wrote:
Move ib_ to efa_ types conversion functions to have them near the types
definitions and to reduce code in efa_verbs.c.

Reviewed-by: Firas Jahjah <firasj@xxxxxxxxxx>
Reviewed-by: Yonatan Nachum <ynachum@xxxxxxxxxx>
Signed-off-by: Michael Margolin <mrgolin@xxxxxxxxxx>
The idea was to not expose these functions in the h file as they are not
used outside of efa_verbs.c.

I know but it's a driver internal header and it also makes sense to have the cast from the base type near the definition.

Michael





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux