On 6/24/2024 8:33 AM, Anand Khoje wrote:
> --- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> @@ -608,6 +608,7 @@ enum {
> RELEASE_ALL_PAGES_MASK = 0x4000,
> };
>
> +#define MAX_RECLAIM_NPAGES -50000
Can you please explain why this is negative? There doesn't seem to be
any reason mentioned in the commit message or code.
At the very least it's super confusing to have a MAX be negative, and at
worst it's a bug. I don't have any other context on this code besides
this patch, so an explanation would be helpful.
