On Mon, 2024-06-17 at 15:54 +0800, Hongfu Li wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
This change looks simple enough to me. Thanks for the clean up.
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> ---
> net/rds/tcp.c | 4 +---
> net/rds/tcp_recv.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index d8111ac83bb6..3dc6956f66f8 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -719,9 +719,7 @@ static int __init rds_tcp_init(void)
> {
> int ret;
>
> - rds_tcp_conn_slab = kmem_cache_create("rds_tcp_connection",
> - sizeof(struct
> rds_tcp_connection),
> - 0, 0, NULL);
> + rds_tcp_conn_slab = KMEM_CACHE(rds_tcp_connection, 0);
> if (!rds_tcp_conn_slab) {
> ret = -ENOMEM;
> goto out;
> diff --git a/net/rds/tcp_recv.c b/net/rds/tcp_recv.c
> index c00f04a1a534..7997a19d1da3 100644
> --- a/net/rds/tcp_recv.c
> +++ b/net/rds/tcp_recv.c
> @@ -337,9 +337,7 @@ void rds_tcp_data_ready(struct sock *sk)
>
> int rds_tcp_recv_init(void)
> {
> - rds_tcp_incoming_slab = kmem_cache_create("rds_tcp_incoming",
> - sizeof(struct
> rds_tcp_incoming),
> - 0, 0, NULL);
> + rds_tcp_incoming_slab = KMEM_CACHE(rds_tcp_incoming, 0);
> if (!rds_tcp_incoming_slab)
> return -ENOMEM;
> return 0;
