> Hi, > > I looked again on the patch 3b73eb3a4acd ("RDMA/mana_ib: Introduce > mana_ib_get_netdev helper function") and wonder if it is correct thing to do. > > All new drivers shouldn't open-code get_netdev() and use the helpers > ib_device_get_netdev() and > ib_device_set_netdev() instead of storing netdev in the driver. > > Can you please convert MANA IB driver to proper API usage? Hi Leon, This helper was introduced to remove a boiler plate code which was getting the netdev from gc->mana.driver_data. I sure can fix it and use ib_device_get_netdev api. Should I send it to the rdma-next on the top of the latest commit? Thanks > > Thanks