On Sat, Jun 01, 2024 at 12:39:13PM +0100, Simon Horman wrote: > On Sat, Jun 01, 2024 at 12:35:57PM +0100, Simon Horman wrote: > > On Wed, May 29, 2024 at 03:16:26AM +0000, Joe Damato wrote: > > > Add two helpers to: > > > > > > 1. Compute the txq_ix given a channel and a tc offset (tc_to_txq_ix). > > > 2. Compute the channel index and tc offset given a txq_ix > > > (txq_ix_to_chtc_ix). > > > > > > The first helper, tc_to_txq_ix, is used in place of the mathematical > > > expressionin mlx5e_open_sqs when txq_ix values are computed. > > > > > > The second helper, txq_ix_to_chtc_ix, will be used in a following patch. > > > > Hi Joe, > > > > I think it would be best to add txq_ix_to_chtc_ix as part of patch that > > uses it, because the current arrangement will cause allmodconfigs with > > clang-18 and W=1 to fail due to txq_ix_to_chtc_ix being unused. > > > > ... > > Sorry, one more thing. > > Please don't use inline in .c files unless there is a demonstrable > reason - f.e. performance - to do so. Rather, let the compiler figure > out when to inline functions. Sure, I'll make sure in the next revision to include the second helper in the second patch instead and avoid using "inline" in both cases.
