> From: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
> Sent: Tuesday, May 28, 2024 8:18 PM
[..]
> mlx5_irq_get_index(least_loaded_irq)), pool->name,
> > mlx5_irq_read_locked(least_loaded_irq) /
> MLX5_EQ_REFS_PER_IRQ);
> > unlock:
> > + if (mlx5_irq_pool_is_sf_pool(pool)) {
> > + ret =
> auxiliary_device_sysfs_irq_add(mlx5_sf_coredev_to_adev(dev),
> > +
> mlx5_irq_get_irq(least_loaded_irq));
> > + if (ret)
> > + mlx5_core_err(dev, "Failed to create sysfs entry for irq
> %d, ret = %d\n",
> > + mlx5_irq_get_irq(least_loaded_irq), ret);
>
> you are handling the error by logging a message, then ignoring it this is clearly
> not an ERROR, just a WARN or INFO.
>
> > + }
> > mutex_unlock(&pool->lock);
> > return least_loaded_irq;
> > }
>
> [...]
I clearly remember discussing/reviewing this internally to error out.
Without it, we didn’t add the entry, but we will try to remove it where the remove function does not expect an error.
Shay,
Error unwinding should happen when fail to create the sysfs entry.
