Hello, On Tue, May 14, 2024 at 01:48:24PM +0000, Haakon Bugge wrote: > > Also, this looks like something that the work function can do on entry and > > before exit, no? > > It _can_ be done in the work functions, but that will be a code sprawl. > Only in RDS, we have the following worker functions: > > rds_ib_odp_mr_worker(); > rds_ib_mr_pool_flush_worker() > rds_ib_odp_mr_worker() > rds_tcp_accept_worker() > rds_connect_worker() > rds_send_worker() > rds_recv_worker() > rds_shutdown_worker() > > adding the ones from ib_cm, rdma_cm, mlx5_ib, and mlx5_core, I strongly > prefer to have it in one place. I haven't seen the code yet, so can't tell for sure but if you're automatically inherting these flags from the scheduling site, I don't think that's gonna work. Note that getting a different, more permissive, allocation context is one of reasons why one might want to use workqueues, so it'd have to be explicit whether it's in workqueue or in its users. Thanks. -- tejun
