..
The off-channels queues (like PTP) do not exist in default. So they are out
of the game unless you explicitly enables them.
I did not enable them, but if you saw the thread, it sounds like Jakub's
preference is that in the v2 I include the PTP stats in get_base_stats.
Are you OK with that?
Sounds good.
Are there other queue stats I should include as well?
The QOS/HTB queues.
See mlx5e_stats_grp_sw_update_stats_qos.
A possible reason for this difference is the queues included in the sum.
Our stats are persistent across configuration changes, so they doesn't reset
when number of channels changes for example.
We keep stats entries for al ring indices that ever existed. Our driver
loops and sums up the stats for all of them, while the stack loops only up
to the current netdev->real_num_rx_queues.
Can this explain the diff here?
Yes, that was it. Sorry I didn't realize this case. My lab machine runs a
script to adjust the queue count shortly after booting.
I disabled that and re-ran:
NETIF=eth0 tools/testing/selftests/drivers/net/stats.py
and all tests pass.
Great!
