Re: [PATCH 1/1] IB: sw: rdmavt: mr: use 'time_left' variable with wait_for_completion_timeout()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > -	timeout = wait_for_completion_timeout(&mr->comp, 5 * HZ);
> > > -	if (!timeout) {
> > > +	time_left = wait_for_completion_timeout(&mr->comp, 5 * HZ);
> > > +	if (!time_left) {
> > >  		rvt_pr_err(rdi,
> > >  			   "%s timeout mr %p pd %p lkey %x refcount %ld\n",
> > >  			   t, mr, mr->pd, mr->lkey,
> > 
> > Nah. Disagree. I think the code is just fine as it is.
> 
> I agree with Dennis. Let's drop this patch.

Okay, I added your subsystem to the discard-list. Thanks for the review
nonetheless!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux