Re: [PATCH 1/2] driver core: auxiliary bus: show auxiliary device IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2024/5/3 19:14, kernel test robot 写道:
Hi Shay,

kernel test robot noticed the following build warnings:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on driver-core/driver-core-next driver-core/driver-core-linus net/main net-next/main linus/master v6.9-rc6 next-20240503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shay-Drory/driver-core-auxiliary-bus-show-auxiliary-device-IRQs/20240503-123319
base:   driver-core/driver-core-testing
patch link:    https://lore.kernel.org/r/20240503043104.381938-2-shayd%40nvidia.com
patch subject: [PATCH 1/2] driver core: auxiliary bus: show auxiliary device IRQs
config: s390-randconfig-r081-20240503 (https://download.01.org/0day-ci/archive/20240504/202405040108.NWUaSJgz-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405040108.NWUaSJgz-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405040108.NWUaSJgz-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/base/auxiliary.c:182: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
     * Auxiliary devices can share IRQs. Expose to user whether the provided IRQ is


vim +182 drivers/base/auxiliary.c

    180	
    181	/**
From the above, "/**" should be "/*"?

Zhu Yanjun
  > 182	 * Auxiliary devices can share IRQs. Expose to user whether the provided IRQ is
    183	 * shared or exclusive.
    184	 */
    185	static ssize_t auxiliary_irq_mode_show(struct device *dev,
    186					       struct device_attribute *attr, char *buf)
    187	{
    188		struct auxiliary_irq_info *info =
    189			container_of(attr, struct auxiliary_irq_info, sysfs_attr);
    190	
    191		if (refcount_read(xa_load(&irqs, info->irq)) > 1)
    192			return sysfs_emit(buf, "%s\n", "shared");
    193		else
    194			return sysfs_emit(buf, "%s\n", "exclusive");
    195	}
    196	






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux