On Fri, Apr 26, 2024 at 01:01:16PM -0700, Jakub Kicinski wrote: > On Fri, 26 Apr 2024 18:33:55 +0000 Joe Damato wrote: > > Make mlx4 compatible with the newly added netlink queue stats API. > > > > Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx> > > Tested-by: Martin Karsten <mkarsten@xxxxxxxxxxxx> > > Not sure what the "master" and "port_up" things are :) > but the rest looks good: So in mlx4_en_DUMP_ETH_STATS, the driver calls mlx4_en_fold_software_stats which does the same "port_up" / "master" check and bails out... so I figured for these stats I should do the same. Was hoping Mellanox would give us a hint, but glancing at the code where the MLX4_FLAG_MASTER bit is set, it looks like sriov ? maybe "master" means pf and "slave" means "vf" ? Not sure why the stats code bails on is_master but not is_slave, though. > Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx> I'll add your reviewed-by to my v3 and wait until sometime mid next week to send the v3. Hopefully we'll hear back from the Mellanox folks by then if they have thoughts/opinions on the stats code.
