Re: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 26, 2024 at 07:50:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 26, 2024 at 01:37:19PM -0300, Jason Gunthorpe wrote:
> > On Tue, Apr 23, 2024 at 11:42:58PM +0300, Andy Shevchenko wrote:
> > > The compilation with CONFIG_WERROR=y is broken:
> > > 
> > > .../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > > 	if (!upper_ndev) {
> > > 	    ^~~~~~~~~~~
> > > 
> > > Fix this by assigning the ret to -ENODEV in respective condition.
> > > 
> > > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/infiniband/hw/mana/device.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > This was fixed in
> 
> Hmm... The below patch had been sent _after_ mine. What's wrong with
> mine patch?

It wasn't

Your's:
Date: Tue, 23 Apr 2024 23:42:58 +0300	[thread overview]

Konstantin's:
Date: Tue, 23 Apr 2024 07:15:51 -0700	[thread overview]

He beat you by 6 hours, which is why I took his, yours didn't exist at
the time I took it.

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux