> Subject: RE: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe with > buf_size > > > From: Long Li <longli@xxxxxxxxxxxxx> > > Sent: Wednesday, 24 April 2024 01:35 > > To: Konstantin Taranov <kotaranov@xxxxxxxxxxxxxxxxxxx>; Konstantin > > Taranov <kotaranov@xxxxxxxxxxxxx>; sharmaajay@xxxxxxxxxxxxx; > > jgg@xxxxxxxx; leon@xxxxxxxxxx > > Cc: linux-rdma@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > Subject: RE: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe > > with buf_size > > > > > Subject: [PATCH rdma-next 3/6] RDMA/mana_ib: replace duplicate cqe > > > with buf_size > > > > I don't understand this commit message on "duplicate" cqe. I couldn't > > find a duplicate of it in the existing code. > > If we need cqe, we could use it at cq->ibcq.cqe. The patch does not assign it as it > is not used, but if you want I can add "cq->ibcq.cqe = attr->cqe;" in v2. > > - Konstantin I see. We don't need buf_size because it can be computed from cq->ibcq.cqe? The commit message is confusing enough to make people think cqe is a duplicate of buf_size. Long
