> > > diff --git a/drivers/infiniband/core/cma.c > > > b/drivers/infiniband/core/cma.c index 1e2cd7c8716e..b6a73c7307ea > > > 100644 > > > --- a/drivers/infiniband/core/cma.c > > > +++ b/drivers/infiniband/core/cma.c > > > @@ -1002,6 +1002,7 @@ __rdma_create_id(struct net *net, > > rdma_cm_event_handler event_handler, > > > id_priv->tos_set = false; > > > id_priv->timeout_set = false; > > > id_priv->min_rnr_timer_set = false; > > > + id_priv->max_cm_retries = false; > > > > max_cm_retries is u8 type. Not sure if it is good to set it as false. > > It could be initialized to CMA_MAX_CM_RETRIES, which would allow removing max_cm_retries_set. > > - Sean I have no objection. It makes sense to have a *_set field for non-constant default (like "tos" value) but not here. Etienne
