On Thu, Apr 18, 2024 at 08:42:59PM +0200, Andrew Lunn wrote: > > >From an RDMA perspective this is all available from other APIs already > > at least and I wouldn't want to see new sysfs unless there is a netdev > > justification. > > It is unlikely there is a netdev justification. Configuration happens > via netlink, not sysfs. > > Andrew Thanks. Sure, it makes sense to make the generic attribute configurable through the netdevice ops or netlink implementation. I will keep that in mind while adding the next set of configuration attributes for the driver. These attributes(from the patch) however, are hardware specific(that show the maximum supported values by the hardware in most cases). We want them to be a part of sysfs so that they are readily available in the production for improving debuggability. I will change the names of these attribute to indicate the same to avoid possible confusion. Regards, Shradha.
