On Tue, 2 Apr 2024 14:25:49 +0300 Parav Pandit wrote:
> + query_ctx = kzalloc(query_out_sz, GFP_KERNEL);
> + if (!query_ctx)
> + return -ENOMEM;
> +
> + mutex_lock(&esw->state_lock);
> + err = mlx5_vport_get_other_func_cap(esw->dev, vport_num, query_ctx,
> + MLX5_CAP_GENERAL);
> + if (err) {
> + NL_SET_ERR_MSG_MOD(extack, "Failed getting HCA caps");
> + goto out;
missing unlock
And before someone suggests we need guards, even make coccicheck catches
this...
> + }
> +
> + hca_caps = MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability);
> + MLX5_SET(cmd_hca_cap, hca_caps, max_num_eqs, max_eqs);
> +
> + err = mlx5_vport_set_other_func_cap(esw->dev, hca_caps, vport_num,
> + MLX5_SET_HCA_CAP_OP_MOD_GENERAL_DEVICE);
> + mutex_unlock(&esw->state_lock);
> + if (err)
> + NL_SET_ERR_MSG_MOD(extack, "Failed setting HCA caps");
> +
> +out:
> + kfree(query_ctx);
> + return err;
--
pw-bot: cr
