Re: [PATCH for-next 01/11] RDMA/rxe: Fix seg fault in rxe_comp_queue_pkt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 26, 2024 at 12:43:16PM -0500, Bob Pearson wrote:
> In rxe_comp_queue_pkt() an incoming response packet skb is enqueued
> to the resp_pkts queue and then a decision is made whether to run the
> completer task inline or schedule it. Finally the skb is dereferenced
> to bump a 'hw' performance counter. This is wrong because if the
> completer task is already running in a separate thread it may have
> already processed the skb and freed it which can cause a seg fault.
> This has been observed infrequently in testing at high scale.
> 
> This patch fixes this by changing the order of enqueuing the packet
> until after the counter is accessed.
> 
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> Fixes: 0b1e5b99a48b ("IB/rxe: Add port protocol stats")

Signed-off-by needs to be after Fixes lines
It is applicable to all patches in this series.

Thanks




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux