> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Sent: Monday, April 1, 2024 4:21 PM > > [...] > > I suggest the Fixes tag should be updated. Otherwise the fix > > looks good to me. > > Thanks for the suggestion. I actually thought about this before > submission. > I was worried about someone back ports the jumbo frame feature, > they may not automatically know this patch should be backported > too. The jumbo frame commit (2fbbd712baf1) depends on the MTU commit (2fbbd712baf1), so adding "Fixes: 2fbbd712baf1" ( instead of "Fixes: ca9c54d2d6a5") might make it easier for people to notice and pick up this fix. I'm OK if the patch remains as is. Just wanted to make sure I understand the issue here. > Also, I suspect that a bigger than MTU packet may cause > unexpected problem at NVA application. Good point. + Wei Hu, who can check the FreeBSD MANA driver and the DPDK MANA PMD. The code there may also need to be fixed. > If anyone have questions on back porting, I can provide a back > ported patch, which is just one line change. > > - Haiyang If the patch remains as is, gregkg will send us "failed to apply" emails for v6.1.y and v5.15.y and we'll need to make a backport for the 2 stable kernels. With "Fixes: 2fbbd712baf1", we won't receive the "failed to apply" emails. Thanks, Dexuan
