Hi,
>-----Original Message-----
>From: Arnd Bergmann <arnd@xxxxxxxxxx>
>Sent: Wednesday, March 27, 2024 4:08 AM
>To: llvm@xxxxxxxxxxxxxxx; Saeed Mahameed <saeedm@xxxxxxxxxx>; Leon
>Romanovsky <leon@xxxxxxxxxx>
>Cc: Arnd Bergmann <arnd@xxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
>Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
>Abeni <pabeni@xxxxxxxxxx>; Nathan Chancellor <nathan@xxxxxxxxxx>; Nick
>Desaulniers <ndesaulniers@xxxxxxxxxx>; Bill Wendling <morbo@xxxxxxxxxx>;
>Justin Stitt <justinstitt@xxxxxxxxxx>; Vlad Buslov <vladbu@xxxxxxxxxx>; Roi
>Dayan <roid@xxxxxxxxxx>; Maor Dickman <maord@xxxxxxxxxx>; Gal Pressman
><gal@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx
>Subject: [PATCH 4/9] mlx5: avoid truncating error message
>
>From: Arnd Bergmann <arnd@xxxxxxxx>
>
>clang warns that one error message is too long for its destination buffer:
>
>drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c:1876:4: error: 'snprintf'
>will always be truncated; specified size is 80, but format string expands to at least
>94 [-Werror,-Wformat-truncation-non-kprintf]
>
>Reword it to be a bit shorter so it always fits.
>
>Fixes: 70f0302b3f20 ("net/mlx5: Bridge, implement mdb offload")
>Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
Thanks,
Sundeep
>---
> drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>index 1b9bc32efd6f..c5ea1d1d2b03 100644
>--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
>@@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device
>*dev, u16 vport_num, u16 esw_
> "Failed to lookup bridge port vlan metadata to
>create MDB (MAC=%pM,vid=%u,vport=%u)\n",
> addr, vid, vport_num);
> NL_SET_ERR_MSG_FMT_MOD(extack,
>- "Failed to lookup bridge port vlan
>metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n",
>+ "Failed to lookup vlan metadata for
>MDB (MAC=%pM,vid=%u,vport=%u)\n",
> addr, vid, vport_num);
> return -EINVAL;
> }
>--
>2.39.2
>
