RE: [PATCH rdma-next v2 4/4] RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs

[Konstantin Taranov <kotaranov@xxxxxxxxxxxxx>]

> > > >  struct mana_ib_qp {
> > > >  	struct ib_qp ibqp;
> > > >
> > > > -	/* Work queue info */
> > > > -	struct ib_umem *sq_umem;
> > > > -	int sqe;
> > > > -	u64 sq_gdma_region;
> > > > -	u64 sq_id;
> > > > -	mana_handle_t tx_object;
> > > > +	struct mana_ib_raw_sq sq;
> > >
> > > Are you planning to add another type of sq for RC here?
> > >
> >
> > There will be no more SQs. There will be rc_qp, ud_qp, uc_qp, which have
> several
> > queues inside.
> 
> Are you going to put rc_qp inside struct mana_ib_qp? Or is it another struct
> containing mana_ib_qp?

It will be like that: 
struct mana_ib_qp {
struct ib_qp ibqp;

union { 
struct mana_ib_raw_sq sq;
struct mana_ib_rc_qp rc_qp;
struct mana_ib_ud_qp ud_qp;
};
};