On Wed, Mar 13, 2024 at 03:33:10AM -0700, Breno Leitao wrote: > struct net_device shouldn't be embedded into any structure, instead, > the owner should use the priv space to embed their state into net_device. "shouldn't" is a strong word, given the fact that original init_dummy_netdev() was designed to be used in such way. > > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct hfi1_netdev_rx by converting it > into a pointer. Then use the leverage alloc_netdev() to allocate the > net_device object at hfi1_alloc_rx(). > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/ > > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> > > ---- > PS: this diff needs d160c66cda0ac8614 ("net: Do not return value from > init_dummy_netdev()") in order to apply and build cleanly. We are in merge window now, so if Dennis approves, I will apply it after the merge window Thanks
