Hi, Chris Added the comments inline. Thanks, Jiping -----Original Message----- From: Friesen, Chris <Chris.Friesen@xxxxxxxxxxxxx> Sent: Friday, March 1, 2024 4:31 AM To: linux-rdma@xxxxxxxxxxxxxxx; selvin.xavier@xxxxxxxxxxxx Cc: Asselstine, Mark <Mark.Asselstine@xxxxxxxxxxxxx>; Ma, Jiping <Jiping.Ma2@xxxxxxxxxxxxx> Subject: question about in-tree vs out-of-tree Broadcom ROCE drivers. Hi, I got your address from the Linux kernel MAINTAINERS file, I was wondering if you could clear something up? As far as I can tell, the in-tree driver at drivers/infiniband/hw/bnxt_re uses a BNXT_RE_ABI_VERSION value of 1, as defined in include/uapi/rdma/bnxt_re-abi.h. On the other hand, the libbnxt_re-228.0.133.0 package and the bnxt_re-228.0.133.0 driver embedded within https://docs.broadcom.com/docs/NXE_Linux_Installer-228.1.111.0 are using a BNXT_RE_ABI_VERSION of 6. [Jiping] The abi_version of OOT bnxt_re driver is 6. BNXT_RE_ABI_VERSION of 6 of libbnxt_re is to compatible with OOT driver. Perhaps libbnxt_re does not consider the in-tree driver. This seems to indicate that the in-tree kernel driver cannot be used with the official version of libbnxt_re as distributed by Broadcom. Is this correct? If so, is there a separate version of libbnxt_re intended to be used with the in-kernel driver? [Jiping] Yes, it looks like. But I did RDMA test, the test passed. So I suggest we can do more full tests for this part, such as wrcp regression test etc. In addition, I did not do more search if there is other libbnxt_re can be used for in-tree driver. Could we also confirm with Broadcom for this question? Thanks, Chris Friesen
