On Wed, Feb 21, 2024 at 12:33 PM Alexey Kodanev
<aleksei.kodanev@xxxxxxxxxxx> wrote:
>
> strnlen() may return 0 (e.g. for "\0\n" string), it's better to
> check the result of strnlen() before using 'len - 1' expression
> for the 'buf' array index.
>
> Detected using the static analysis tool - Svace.
>
> Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")
> Signed-off-by: Alexey Kodanev <aleksei.kodanev@xxxxxxxxxxx>
lgtm, thx
Acked-by: Jack Wang <jinpu.wang@xxxxxxxxx>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> index d3c436ead694..4aa80c9388f0 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> @@ -133,7 +133,7 @@ static ssize_t mpath_policy_store(struct device *dev,
>
> /* distinguish "mi" and "min-latency" with length */
> len = strnlen(buf, NAME_MAX);
> - if (buf[len - 1] == '\n')
> + if (len && buf[len - 1] == '\n')
> len--;
>
> if (!strncasecmp(buf, "round-robin", 11) ||
> --
> 2.25.1
>
