On Wed, 2024-02-07 at 09:59 -0800, Jakub Kicinski wrote: > On Wed, 7 Feb 2024 17:23:53 +0000 Allison Henderson wrote: > > > This is not a correct Fixes tag. Please look at git history > > > > Sorry, the fixes tag identifies the offending commit? I think it's > > an > > existing bug since the code was introduced. Which would be: > > > > Fixes: bdbe6fbc6a2f (RDS: recv.c) > > > > If that's not a useful tag, I can remove it too. The syzbot bisect > > points to a virtio commit 1628c6877f37, but that doesn't look > > correct > > to me. Let me know what you would prefer. Thank you! > > The initial commit for the code base is very useful to backporters! > It tells them "you have to backport this all the way down". > Lack of a Fixes tag says "I don't know where the bug was added". > > Fixes tags are more about telling backporters how far to backport > than about blame. Alrighty then, I will update the Fixes tag with the line above and resend. Thank you for the reviews! Allison
