Hello Leon, > > The attributes array `tb` in ib_nl_is_good_resolve_resp is never used > > after the parsing. Therefore use nla_validate_deprecated function here > > for improvement. > > What did this change improve? > To my concern, the nla_validate_deprecated, compared to nla_parse_deprecated, will at lease save a memset in function nla_parse_deprecated ``` if (tb) memset(tb, 0, sizeof(struct nlattr *) * (maxtype + 1)); ``` Morever, because the `nla_validate_deprecated` just validate the attributes array and will not try to retrieve the nla pointers. It shall be faster and cleaner here :D. Regards Lin