On Tue, Nov 28, 2023 at 05:40:53PM +0800, Dinghao Liu wrote: > When kcalloc() for ft->g succeeds but kvzalloc() for in fails, > fs_udp_create_groups() will free ft->g. However, its caller > fs_udp_create_table() will free ft->g again through calling > mlx5e_destroy_flow_table(), which will lead to a double-free. > Fix this by setting ft->g to NULL in fs_udp_create_groups(). > > Fixes: 1c80bd684388 ("net/mlx5e: Introduce Flow Steering UDP API") > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx> > --- > > Changelog: > > v2: Setting ft->g to NULL instead of removing the kfree(). Reviewed-by: Simon Horman <horms@xxxxxxxxxx>