在 2023/11/7 1:31, Bob Pearson 写道:
On 11/6/23 07:26, Zhu Yanjun wrote:
在 2023/11/6 4:19, Bob Pearson 写道:
On 11/4/23 07:42, Zhu Yanjun wrote:
Using reverse fir tree, a.k.a. reverse Christmas tree or reverse
XMAS tree, for
variable declarations isn't strictly required, though it is still
preferred.
Zhu Yanjun
Yeah. I usually follow that style for new code (except if there are
dependencies) but mostly add new variables at the end of the list
together because it makes the patch simpler to read. At least it
does for me. If you care, I am happy to fix this.
Yes. It is good to fix it.
And your commits add mcast address supports. And I think you
should have the test case in the rdma-core to verify these commits.
Can you share the test case in the rdma maillist? ^_^
Zhu Yanjun
Bob
I could share it but it's not really in a good shape to publish. I
have to modify the limits in rxe_param.h to test max_etc. And currently
I need to hand edit the send/recv versions to do node to node. In other
words just enough to (by hand) work through the use cases enough to
convince myself it works using ip maddr and wireshark along with the
program.
What you are asking for is a bunch of work to make the test program
more like iperf or ib_send_bw. Ideally it should either reload the
driver or do something else to let each test case be a clean start.
Got it.
Anyway, a test case in rdma-core is needed to make tests with this feature.
And this feature is related with mcast. So please also send these
commits to NETDEV maillist. NETDEV people can also give us a lot of good
advice.
Thanks,
Zhu Yanjun
In an ideal world there would be a two node version of pyverbs. :-)
Bob
