On 10/27/23 20:44, Bernard Metzler wrote:
-----Original Message-----
From: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
Sent: Friday, October 27, 2023 4:33 AM
To: Bernard Metzler <BMT@xxxxxxxxxxxxxx>; jgg@xxxxxxxx; leon@xxxxxxxxxx
Cc: linux-rdma@xxxxxxxxxxxxxxx
Subject: [EXTERNAL] [PATCH V3 08/18] RDMA/siw: Factor out siw_generic_rx
helper
Remove the redundant code given they share the same logic.
Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
---
drivers/infiniband/sw/siw/siw_qp_rx.c | 53 ++++++++++-----------------
1 file changed, 20 insertions(+), 33 deletions(-)
diff --git a/drivers/infiniband/sw/siw/siw_qp_rx.c
b/drivers/infiniband/sw/siw/siw_qp_rx.c
index 10805a7d0487..2a6473a5abe0 100644
--- a/drivers/infiniband/sw/siw/siw_qp_rx.c
+++ b/drivers/infiniband/sw/siw/siw_qp_rx.c
@@ -405,6 +405,20 @@ static struct siw_wqe *siw_rqe_get(struct siw_qp *qp)
return wqe;
}
Maybe better call it siw_rx_data()?
Ok, will change it in new version.
For a 'generic receive' I could imagine 1000 things.
You made an abstraction for receiving different types
of payload.
Right.
Thanks,
Guoqing
