> Subject: Re: [PATCH] hv_netvsc: Mark VF as slave before exposing it to user-mode > > On Wed, 25 Oct 2023 15:50:50 -0700 > longli@xxxxxxxxxxxxxxxxx wrote: > > > list_for_each_entry(ndev_ctx, &netvsc_dev_list, list) { > > ndev = hv_get_drvdata(ndev_ctx->device_ctx); > > - if (ether_addr_equal(vf_netdev->perm_addr, ndev->perm_addr)) > { > > - netdev_notice(vf_netdev, > > - "falling back to mac addr based > matching\n"); > > + if (ether_addr_equal(vf_netdev->perm_addr, ndev->perm_addr) > || > > + ether_addr_equal(vf_netdev->dev_addr, ndev->perm_addr)) > > This part looks like unrelated change. > The VF mac address shouldn't change, but if it did don't look at i. At the time of NETDEV_POST_INIT, the perm_addr is not assigned yet (last it was copied from dev_addr when device is registered).