> -----Original Message-----
> From: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
> Sent: Monday, October 9, 2023 9:18 AM
> To: Bernard Metzler <BMT@xxxxxxxxxxxxxx>; jgg@xxxxxxxx; leon@xxxxxxxxxx
> Cc: linux-rdma@xxxxxxxxxxxxxxx
> Subject: [EXTERNAL] [PATCH 04/19] RDMA/siw: Remove goto lable in siw_mmap
>
> Remove unnecessary label since the failure case only need to
> print warning message.
I think you suggest removing it since the code falls through to the
useless label anyway and not since it prints a warning.
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
> ---
> drivers/infiniband/sw/siw/siw_verbs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
> b/drivers/infiniband/sw/siw/siw_verbs.c
> index c5c27db9c2fe..dcd69fc01176 100644
> --- a/drivers/infiniband/sw/siw/siw_verbs.c
> +++ b/drivers/infiniband/sw/siw/siw_verbs.c
> @@ -66,12 +66,9 @@ int siw_mmap(struct ib_ucontext *ctx, struct
> vm_area_struct *vma)
> entry = to_siw_mmap_entry(rdma_entry);
>
> rv = remap_vmalloc_range(vma, entry->address, 0);
> - if (rv) {
> + if (rv)
> pr_warn("remap_vmalloc_range failed: %lu, %zu\n", vma->vm_pgoff,
> size);
> - goto out;
> - }
> -out:
> rdma_user_mmap_entry_put(rdma_entry);
>
> return rv;
> --
> 2.35.3
Thanks, makes sense!
Acked-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
