On 10/24/23 10:09 AM, Petr Machata wrote: > > Patrisious Haddad <phaddad@xxxxxxxxxx> writes: > >> Signed-off-by: Patrisious Haddad <phaddad@xxxxxxxxxx> >> Reviewed-by: Michael Guralnik <michaelgur@xxxxxxxxxx> >> --- >> man/man8/rdma-system.8 | 32 +++++++++++++++++++++++++++----- >> 1 file changed, 27 insertions(+), 5 deletions(-) >> >> diff --git a/man/man8/rdma-system.8 b/man/man8/rdma-system.8 >> index ab1d89fd..a2914eb8 100644 >> --- a/man/man8/rdma-system.8 >> +++ b/man/man8/rdma-system.8 >> @@ -23,16 +23,16 @@ rdma-system \- RDMA subsystem configuration >> >> .ti -8 >> .B rdma system set >> -.BR netns >> -.BR NEWMODE >> +.BR netns/privileged_qkey >> +.BR NEWMODE/NEWSTATE > > What is this netns/priveleged_qkey syntax? I thought they are > independent options. If so, the way to express it is: > > rdma system set [netns NEWMODE] [privileged_qkey NEWSTATE] > > Also, your option is not actually privileged_qkey, but privileged-qkey. yes, and the command lines below show 'privileged qkey' > >> .ti -8 >> .B rdma system help >> >> .SH "DESCRIPTION" >> -.SS rdma system set - set RDMA subsystem network namespace mode >> +.SS rdma system set - set RDMA subsystem network namespace mode or privileged qkey mode >> >> -.SS rdma system show - display RDMA subsystem network namespace mode >> +.SS rdma system show - display RDMA subsystem network namespace mode and privileged qkey state > > Maybe make it just something like "configure RDMA system settings" or > whatever the umbrella term is? The next option will certainly have to do > something, this doesn't scale. > > Plus the lines are waaay over 80, even over 90 that I think I've seen > Stephen or David mention as OK for iproute2 code. a few over 80 is ok when it improves readability; over 90 (with the exception of print strings) is unacceptable.
