On Thu, 21 Sep 2023 07:17:47 +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We see that `buf` is expected to be NUL-terminated based on it's use
> within a trace event wherein `is_misc_err_name` and `is_various_name`
> map to `is_name` through `is_table`:
> | TRACE_EVENT(hfi1_interrupt,
> | TP_PROTO(struct hfi1_devdata *dd, const struct is_table *is_entry,
> | int src),
> | TP_ARGS(dd, is_entry, src),
> | TP_STRUCT__entry(DD_DEV_ENTRY(dd)
> | __array(char, buf, 64)
> | __field(int, src)
> | ),
> | TP_fast_assign(DD_DEV_ASSIGN(dd);
> | is_entry->is_name(__entry->buf, 64,
> | src - is_entry->start);
> | __entry->src = src;
> | ),
> | TP_printk("[%s] source: %s [%d]", __get_str(dev), __entry->buf,
> | __entry->src)
> | );
>
> [...]
Applied, thanks!
[1/1] IB/hfi1: replace deprecated strncpy
https://git.kernel.org/rdma/rdma/c/c2d0c5b28a77d5
Best regards,
--
Leon Romanovsky <leon@xxxxxxxxxx>
