On Tue, Sep 19, 2023 at 4:06 PM Vitaly Mayatskikh <vitaly@xxxxxxxxxxxxx> wrote:
>
> On Tue, Sep 19, 2023 at 3:21 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> > I see that rdma_protocol_iwarp() is used in other places in cma.c too,
> > Don't they need to be updated too?
> >
> > Also I see that we have check for protocol RoCE in else before the
> > changed line, shouldn't all cma.c be changed to rdma_cap_*_cm() calls?
> >
> > 3376 else if (rdma_protocol_roce(id->device, id->port_num)) {
>
> I can't really judge, but looking around in the code it seems that
> some if not all of
> those cma.c functions that are checking for the protocol - they only
> called from the
> drivers that actually use the protocol. For example, iSER.
>
> Our driver does not support iWarp, but implements IW_CM callbacks. The patch has
> the only fix that was needed to make it work w/o a full blown iWarp.
Ugh, adding everyone back...
