On 2023-08-31 20:02, Jason Gunthorpe wrote:
On Thu, Aug 31, 2023 at 10:22:25AM -0400, Kamal Heib wrote:
This patch adds support for reporting the ipoib net device for a given
RDMA device by calling ib_get_net_dev_by_params() when filling the
port's info.
$ rdma link show mlx5_0/1
link mlx5_0/1 subnet_prefix fe80:0000:0000:0000 lid 66 sm_lid 3 lmc 0
state ACTIVE physical_state LINK_UP netdev ibp196s0f0
Signed-off-by: Kamal Heib <kheib@xxxxxxxxxx>
---
drivers/infiniband/core/nldev.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
Are we sure we want to do this? How does it work with namespaces?
You are right, I'll fix it.
@@ -340,6 +341,21 @@ static int fill_port_info(struct sk_buff *msg,
return -EMSGSIZE;
if (nla_put_u8(msg, RDMA_NLDEV_ATTR_LMC, attr.lmc))
return -EMSGSIZE;
+ ipoib_netdev = ib_get_net_dev_by_params(device, port,
+ IB_DEFAULT_PKEY_FULL,
+ NULL, NULL);
And it doesn't work at all for non-default ipoib interfaces?
I'll fix it.
Thanks,
Kamal
Jason
