Re: [PATCH] RDMA/srp: Do not call scsi_done() from srp_abort()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 23 Aug 2023 13:57:27 -0700, Bart Van Assche wrote:
> After scmd_eh_abort_handler() has called the SCSI LLD eh_abort_handler
> callback, it performs one of the following actions:
> * Call scsi_queue_insert().
> * Call scsi_finish_command().
> * Call scsi_eh_scmd_add().
> Hence, SCSI abort handlers must not call scsi_done(). Otherwise all
> the above actions would trigger a use-after-free. Hence remove the
> scsi_done() call from srp_abort(). Keep the srp_free_req() call
> before returning SUCCESS because we may not see the command again if
> SUCCESS is returned.
> 
> [...]

Applied, thanks!

[1/1] RDMA/srp: Do not call scsi_done() from srp_abort()
      https://git.kernel.org/rdma/rdma/c/e193b7955dfad6

Best regards,
-- 
Leon Romanovsky <leon@xxxxxxxxxx>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux